Skip to content

Conversation

@tomalec
Copy link

@tomalec tomalec commented May 12, 2016

I found out that Examples 33 and 37 are incompatible with <grid-line> definition at https://drafts.csswg.org/css-grid/#line-placement

<grid-line> =
  auto |
  <custom-ident> |
  [ <integer> && <custom-ident>? ] |
  [ span && [ <integer> || <custom-ident> ] ]

As they use:

grid-row: text 5 / text 7;

So more like <custom-ident>? <integer>

This PR updates examples to:

grid-row: 5 text / 7 text;

@tabatkins
Copy link
Member

The && in [ <integer> && <custom-ident>? ] indicates that the two branches must occur, but can do so in any order, so the current examples are perfectly correct (and so are yours).

I just realized that grammar block wasn't marked up properly to give you the convenient linking from syntax operators to definitions, so that's fixed now.

@tabatkins tabatkins closed this May 13, 2016
frivoal pushed a commit to frivoal/csswg-drafts that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants